From cd3ea6d81304155d7c2be722e763d675717ff06e Mon Sep 17 00:00:00 2001 From: The Magician Date: Thu, 23 Jan 2025 13:04:54 -0800 Subject: [PATCH] Fix Spanner Instance `force_delete` backup bug (#12836) (#9132) [upstream:17465b2bc0d3266584a31a378eba066dd546ab6e] Signed-off-by: Modular Magician --- .changelog/12836.txt | 3 +++ google-beta/services/spanner/resource_spanner_instance.go | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) create mode 100644 .changelog/12836.txt diff --git a/.changelog/12836.txt b/.changelog/12836.txt new file mode 100644 index 0000000000..dac997885d --- /dev/null +++ b/.changelog/12836.txt @@ -0,0 +1,3 @@ +```release-note:bug +spanner: fixed bug with `google_spanner_instance.force_destroy` not setting `billing_project` value correctly +``` \ No newline at end of file diff --git a/google-beta/services/spanner/resource_spanner_instance.go b/google-beta/services/spanner/resource_spanner_instance.go index dd295ad1f3..1724c15868 100644 --- a/google-beta/services/spanner/resource_spanner_instance.go +++ b/google-beta/services/spanner/resource_spanner_instance.go @@ -773,7 +773,7 @@ func resourceSpannerInstanceDelete(d *schema.ResourceData, meta interface{}) err return transport_tpg.HandleNotFoundError(err, d, fmt.Sprintf("SpannerInstance %q", d.Id())) } - err = deleteSpannerBackups(d, config, resp, billingProject, userAgent) + err = deleteSpannerBackups(d, config, resp, userAgent, billingProject) if err != nil { return err }