Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test(s): TestAccComputeNetworkFirewallPolicyRule_multipleRules #19218

Closed
c2thorn opened this issue Aug 21, 2024 · 3 comments
Closed

Failing test(s): TestAccComputeNetworkFirewallPolicyRule_multipleRules #19218

c2thorn opened this issue Aug 21, 2024 · 3 comments

Comments

@c2thorn
Copy link
Collaborator

c2thorn commented Aug 21, 2024

Impacted tests

  • TestAccComputeNetworkFirewallPolicyRule_multipleRules

Affected Resource(s)

  • google_compute_network_firewall_policy_rule

Failure rates

  • 100% since 2024-08-15

Message(s)

        Error: Error updating NetworkFirewallPolicy "projects/<project>/global/firewallPolicies/<name>": googleapi: Error 412: Invalid fingerprint., conditionNotMet

Nightly build test history

b/371061044

@c2thorn c2thorn changed the title Failing test(s): TestAccWhatever Failing test(s): TestAccComputeNetworkFirewallPolicyRule_multipleRules Aug 21, 2024
@c2thorn
Copy link
Collaborator Author

c2thorn commented Aug 22, 2024

skipping in VCR: GoogleCloudPlatform/magic-modules#11522

@mihhalj
Copy link

mihhalj commented Jan 24, 2025

Hi c2thorn, I cannot reproduce it - I checked out the latest terraform-provider-google and run:

make testacc TEST=./google/services/compute TESTARGS='-run=TestAccComputeNetworkFirewallPolicyRule_multipleRules'
TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/services/compute -v -run=TestAccComputeNetworkFirewallPolicyRule_multipleRules -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccComputeNetworkFirewallPolicyRule_multipleRules
=== PAUSE TestAccComputeNetworkFirewallPolicyRule_multipleRules
=== CONT  TestAccComputeNetworkFirewallPolicyRule_multipleRules
--- PASS: TestAccComputeNetworkFirewallPolicyRule_multipleRules (153.64s)
PASS
ok      github.com/hashicorp/terraform-provider-google/google/services/compute  153.792s

In the logs I see rules successfully created/updated.

There's also no acctest.SkipIfVcr(t) in the TestAccComputeNetworkFirewallPolicyRule_multipleRules added in this PR GoogleCloudPlatform/magic-modules#11522

I don't have access to
https://hashicorp.teamcity.com/test/3924032820256974661?currentProjectId=TerraformProviders_GoogleCloud_GOOGLE_BETA_NIGHTLYTESTS&expandTestHistoryChartSection=true - Can you verify if this test still fails there?

@c2thorn
Copy link
Collaborator Author

c2thorn commented Jan 24, 2025

Thank you for checking @mihhalj, it looks like this started passing late last year. I will close.

@c2thorn c2thorn closed this as completed Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants