Make issue labeler apply service/terraform label if more than 3 services are impacted

[melinath]

What kind of contribution is this issue about?

Other (specify in details)

Details

Currently we can end up applying a large number of labels to cross-product issues. We should instead label them with service/terraform.

Note: this may also have impact on how we label PRs (though that may have similar logic.) There may be an opportunity to consolidate the implementations.

References

#20729

[roaks3]

I think there are valid issues that involve multiple service teams where we would want to forward to each team, but that situation gets less likely as the number of services increases. Perhaps we just set a threshold (like 4 or more) where we consider involvement of that many services means it is actually a provider-level issue. Note though that this solution would not cleanly allow for overriding this assumption; we would probably need to split the issue in those cases.

[melinath]

TBH I've been wondering if we should "force"/require splits of any issues with more than one label... it muddies the water in terms of responsibility.

[melinath]

Although in the context of this ticket, that would mean:

• more than three -> service/terraform
• 2 or 3 -> split

[roaks3]

Yea, and:

• more than three that actually should be forwarded to those service teams -> split

Also, I somehow missed the title on the first read, so my previous comment probably seems a bit weird, but also I'm glad I came to the same solution anyway!