New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nunjucks/code blocks in HTML comments were incorrectly converted #5616

Open

D-Sketon wants to merge 1 commit into hexojs:master from D-Sketon:fix/comment

Member

D-Sketon commented Jan 18, 2025 •

edited

Loading

What does it do?

Screenshots

Pull request tasks

Add test cases for the changes.
Passed the CI test.


          fix: nunjucks/codefence nesting in comments

afa9d22

github-actions bot commented Jan 18, 2025

How to test

git clone -b fix/comment https://github.com/D-Sketon/hexo.git
cd hexo
npm install
npm test

coveralls commented Jan 18, 2025

Pull Request Test Coverage Report for Build 12841340167

Details

13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.001%) to 99.483%

Totals
Change from base Build 12702421469:	0.001%
Covered Lines:	9423
Relevant Lines:	9472

💛 - Coveralls

uiolee reviewed

View reviewed changes

test/scripts/hexo/post.ts

+                  data.content.should.eql([
+                    '<p>foo</p>',
+                    '<!--',
+                    `<hexoPostRenderCodeBlock>${highlighted}</hexoPostRenderCodeBlock>`,

This comment was marked as off-topic.

Sign in to view

Member Author

D-Sketon Jan 22, 2025

maybe we can solve it in backtick_code_block.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet