Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-fluidize material data for porous media flow #930

Open
tulioricci opened this issue Jul 12, 2023 · 0 comments
Open

De-fluidize material data for porous media flow #930

tulioricci opened this issue Jul 12, 2023 · 0 comments

Comments

@tulioricci
Copy link
Collaborator

tulioricci commented Jul 12, 2023

Mostly as a reminder, we should think of a way to untangle material properties to fluid properties for porous media flow following review of PR #875. Currently, it is all stashed in gas_model and fluid_state since it is passed everywhere around in the code. Although this contradicts the naming, porous media flow requires a "porous media", we can refactor the current proposed structure for organization and clearness,.

Future physics-targeted experiments+simulations will have to go deeper in this topic. Thus, not-so-distant extra implementations will likely be a good point in tackling this.

@majosm @MTCam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant