Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break out into separate assembly #332

Open
intvsteve opened this issue Oct 17, 2019 · 1 comment
Open

Break out into separate assembly #332

intvsteve opened this issue Oct 17, 2019 · 1 comment
Assignees

Comments

@intvsteve
Copy link
Owner

Make compressed archive access be discovered via MEF so it's more completely isolated.

@intvsteve intvsteve self-assigned this Oct 17, 2019
@intvsteve
Copy link
Owner Author

intvsteve commented Oct 17, 2019

Unlikely that we're going to do this:

  • Use of PathUtils (INTV.Shared)
  • Use of TemporaryDirectory (INTV.Shared)
  • Use of PathComparer (INTV.Shared)

So, while it's possible it could be made, it's likely one or more of the following would also need more work:

  • IRomHelpers(barely aware ofICompressedArchiveAccess`)
  • StorageLocationExtensions makes significant use of it

There may be a few other types that have leaked out to the wider code as well.

Possibly the IStorageAccess interface and StorageLocation type could be extended to make this more completely transparent. However, the notion of needing to know about archive is still necessary when we consider backup / restore features - meaning that the interfaces would either need to be defined in INTV.Core or INTV.Shared anyway, and we'd face possibly more MEF fun`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant