Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

selectedItems not updating based on changes from state #156

Closed
dannysun2 opened this issue Jun 12, 2019 · 3 comments · May be fixed by #157
Closed

selectedItems not updating based on changes from state #156

dannysun2 opened this issue Jun 12, 2019 · 3 comments · May be fixed by #157

Comments

@dannysun2
Copy link

Expected Behavior

Removing names (state.options) from list via onclick results in a re-render should result in an updated selectedItems list to reflect the changes from the state.

https://github.com/dannysun2/react-multi-select

Jun-12-2019 16-51-43

Actual Behavior

While the component re-renders, the selectedItems list fails to reflect the new state changes.

Steps to Reproduce the Problem

  1. Click a name to remove from list
  2. Right side (selected items list) shows "6 Selected" however, the list still shows 7 selections.
@liorheber
Copy link
Collaborator

Hi @dannysun2
Thank you for your issue.

It seems that we've never implemented the component as a controlled component, meaning that the selectedItems is basically used for initialization at this point.
I believe it would make a lot of sense to make the component work in a controlled state and I think the solution is quite simple if I'm honest.

I can't commit on a timeline at this point for a fix so I'd like to encourage you to contribute a solution to this.
I think using a lifecycle method to update the selectedItems in the state in case that the selectedItems are defined and changed should most likely solve this.

Please let me know if you're interested in issuing a PR. Otherwise, I hope we can get someone on this a little later in the future.

Thanks again!

@liorheber liorheber mentioned this issue Jun 12, 2019
Open
danielinacio pushed a commit to danielinacio/react-multi-select that referenced this issue Jun 28, 2019
@danielfreitasjnr-luizalabs
Issue kenshoo#156 - Fixed update of prop selectedItems when state cha…
72c9f30 
…nges
@danielinacio danielinacio mentioned this issue Jun 28, 2019
Open
baptwaels added a commit to baptwaels/react-multi-select that referenced this issue Jul 11, 2019
@baptwaels
MultiSelect can be used as a controlled component (kenshoo#156)
11db008
baptwaels added a commit to baptwaels/react-multi-select that referenced this issue Jul 11, 2019
@baptwaels
MultiSelect can be used as a controlled component (kenshoo#156)
15d7082
baptwaels added a commit to baptwaels/react-multi-select that referenced this issue Jul 11, 2019
@baptwaels
MultiSelect can be used as a controlled component (kenshoo#156)
15ca09a
baptwaels added a commit to baptwaels/react-multi-select that referenced this issue Jul 11, 2019
@baptwaels
MultiSelect can be used as a controlled component (kenshoo#156)
cc83cce
baptwaels added a commit to baptwaels/react-multi-select that referenced this issue Jul 12, 2019
@baptwaels
MultiSelect can be used as a controlled component (kenshoo#156)
488487d
liorheber pushed a commit that referenced this issue Jul 23, 2019
@baptwaels @liorheber
MultiSelect can be used as a controlled component (#156) (#160)
01e6017
@baptwaels
Copy link
Contributor

Controlled component feature implemented in #160

@yegor-babiy
Copy link
Contributor

As fix was pushed , I close thread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #156 - Fixed update of prop selectedItems when state changes danielinacio/react-multi-select
4 participants
@yegor-babiy @liorheber @baptwaels @dannysun2