Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kiwix-serve: external link blocker does not respect the target attribute #1166

Open
benoit74 opened this issue Dec 9, 2024 · 0 comments
Open

Kiwix-serve: external link blocker does not respect the target attribute #1166

benoit74 opened this issue Dec 9, 2024 · 0 comments
Labels
bug kiwix-serve
Milestone
14.1.0

Comments

@benoit74
Copy link

benoit74 commented Dec 9, 2024

See e.g. https://dev.library.kiwix.org/viewer#libretexts.org_en_workforce_2024-12/index.html (or any other libretexts ZIM in dev library ... or prod soon hopefully).

When you click on the blue globe in the top right corner, the target is _blank but the external link blocker opens in same tab.

Image

Image
@benoit74 benoit74 added the bug label Dec 9, 2024
@kelson42 kelson42 added this to the 14.1.0 milestone Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug kiwix-serve
Projects
None yet
Milestone
14.1.0
Development

No branches or pull requests
2 participants
@kelson42 @benoit74