Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate DB Manager args to be managed by environment variables #2500

Open
caiofralmeida opened this issue Jan 22, 2025 · 5 comments
Open

Migrate DB Manager args to be managed by environment variables #2500

caiofralmeida opened this issue Jan 22, 2025 · 5 comments
Assignees

Comments

@caiofralmeida
Copy link
Contributor

After opening a PR parameterizing the DB manager's listen-address via ARGs, @andreyvelich suggested that we standardize all component configurations in environment variables since we have several configurations present, see docs.

The idea is to move the listen-address and connect-timeout arguments to environment variables, update documentation, and make a deprecation notice for the new version.

@tenzen-y
Copy link
Member

/kind feature

@caiofralmeida caiofralmeida changed the title Migrate DB Manager args to managed by environment variables Migrate DB Manager args to be managed by environment variables Jan 22, 2025
@caiofralmeida
Copy link
Contributor Author

@tenzen-y could you please assign this issue to me? I would like to implement it :)

@tenzen-y
Copy link
Member

@tenzen-y could you please assign this issue to me? I would like to implement it :)

Thank you for your help. Feel free to take this issue with /assign comment.

@caiofralmeida
Copy link
Contributor Author

/assign

@andreyvelich
Copy link
Member

andreyvelich commented Jan 22, 2025

Thank you for creating this @caiofralmeida!
Should we directly migrate Katib DB Manager config to Katib Config as part of this work: https://www.kubeflow.org/docs/components/katib/user-guides/katib-config/?
E.g. we should have a new section like:

init:
  dbManager:
    ....

We discussed before that we want to have unify config to control all Katib system settings to simplify user experience.

I understand that it is more work, but we don't need to rush with the implementation.
WDYT @caiofralmeida @tenzen-y @Electronic-Waste ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants