Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codal.json target.dev property looks like a boolean but it isn't #63

Open
microbit-carlos opened this issue Feb 13, 2023 · 0 comments
Open

Comments

@microbit-carlos
Copy link
Collaborator

microbit-carlos commented Feb 13, 2023

The CMakeLists.txt file just check if it has any value, so if the user sets "dev": false in the json file, it will still treat it as a dev build.

if("${codal.target.dev}" STRGREATER "")
file(READ "./${LIB_DEST}/${codal.target.name}/target.json" device_json)
message("${BoldMagenta}Using target.json (dev version) ${ColourReset}")
else()
file(READ "./${LIB_DEST}/${codal.target.name}/target-locked.json" device_json)
message("${BoldMagenta}Using target-locked.json${ColourReset}")
endif()

As the codal.json file in this repository contains "dev": true it's a fair expectation that changing it to false should disable it.

A fix in this repo should also be pushed upstream to lancaster-university/codal and to codal bootstrap (if applicable).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant