Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCAG 2.2: Use aria-errormessage to associate the error message with the input on the "Keyboard shortcuts" page. #11637

Open
pedr opened this issue Jan 13, 2025 · 1 comment
Labels
accessibility Related to accessibility

Comments

@pedr
Copy link
Collaborator

pedr commented Jan 13, 2025

I'm creating an issue for this because I'm not sure if I understand the idea here. Should we associate the error from the import to the aria-errormessage or it is the error that happens when you try to assign a shortcut that is already used? (error that appears on the icon on the left)?

Can you help me @personalizedrefrigerator

image

image

@personalizedrefrigerator personalizedrefrigerator changed the title [❗] Use aria-errormessage to associate the error message with the input on the "Keyboard shortcuts" page. WCAG 2.2: Use aria-errormessage to associate the error message with the input on the "Keyboard shortcuts" page. Jan 13, 2025
@personalizedrefrigerator
Copy link
Collaborator

personalizedrefrigerator commented Jan 13, 2025

I can work on this one! The issue was a follow-up to a refactoring of the keyboard shortcuts screen (#11232). The aria-invalid attribute was added to the shortcut recorder inputs without a link to the error message using aria-errormessage.

Update: So far, aria-errormessage doesn't seem to be working with the keyboard input and the Orca screen reader. I'm putting this on hold for now.

personalizedrefrigerator added a commit to personalizedrefrigerator/joplin that referenced this issue Jan 14, 2025
…puts in the keyboard shortcuts screen using aria
@personalizedrefrigerator personalizedrefrigerator added the accessibility Related to accessibility label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Related to accessibility
Projects
None yet
Development

No branches or pull requests

2 participants