Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract contacts libraries to another project and use it #184

Open
2 of 6 tasks
alagane opened this issue Jan 25, 2022 · 0 comments
Open
2 of 6 tasks

Extract contacts libraries to another project and use it #184

alagane opened this issue Jan 25, 2022 · 0 comments
Assignees

Comments

@alagane
Copy link
Member

alagane commented Jan 25, 2022

In order to remove dependency links between SPAs, contacts libraries should be extracted to a new project and used as a dependency for SPAs needing them.

The new project will be named esn-frontend-contacts-libs.
It will be "forked" (cannot literally fork it with GitHub on the same organisation, only one fork permitted AND no issue can be created on fork) from this project, so the git file history of the libraries files can still be viewed easily.

Tasks

  • Create a branch for the libraries, without the SPA files.
  • Merge it on esn-frontend-contacts-libs
  • Use esn-frontend-contacts-libs instead of esn-frontend-contacts for esn-frontend-admin
  • Create a branch where the SPA uses esn-frontend-contacts-libs dependency, and the libraries code is removed
  • Merge it on esn-frontend-contacts
  • Clean unneeded code and dependencies on each project after the extraction
alagane added a commit to alagane/esn-frontend-contacts that referenced this issue Jan 25, 2022
@alagane alagane self-assigned this Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant