Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we don't measure latency metrics in failure cases #3096

Open
ndr-ds opened this issue Jan 7, 2025 · 0 comments
Open

Make sure we don't measure latency metrics in failure cases #3096

ndr-ds opened this issue Jan 7, 2025 · 0 comments

Comments

@ndr-ds
Copy link
Contributor

ndr-ds commented Jan 7, 2025

We currently measure latency with drop guards in a lot of places. The issue with that is that in case of failure we could report potentially lower latency numbers, even though they're not “valid” per se since we failed. So our latency metrics will basically be inversely proportional to our failure rate. And any failures will pollute our latency metrics and drag it down

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant