Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade assemblyscript + as-pect #338

Closed
peterjah opened this issue Oct 5, 2023 · 3 comments
Closed

Upgrade assemblyscript + as-pect #338

peterjah opened this issue Oct 5, 2023 · 3 comments

Comments

@peterjah
Copy link
Contributor

peterjah commented Oct 5, 2023

we are at least 2 major version behind the latest AS version.
Upgrade will allow us to get back the coverage of as code...
@Ben-Rey
Copy link
Contributor

Ben-Rey commented Nov 8, 2023

I think we need to wait for as-pect/visitor-as#44 and as-pect/as-covers#13 to be able to make the coverage works

@AurelienFT
Copy link
Contributor

@Ben-Rey as-pect is unmaintained I propose that we host a fork where we include the changes of the PR mentioned above.

The update of assemblyscript will impact all the tooling and should be thinking more globally, no ?

@Ben-Rey
Copy link
Contributor

Ben-Rey commented Feb 14, 2024

@Ben-Rey as-pect is unmaintained I propose that we host a fork where we include the changes of the PR mentioned above.

The update of assemblyscript will impact all the tooling and should be thinking more globally, no ?

You're right, I can take care of that.

@Ben-Rey Ben-Rey closed this as completed Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

338-upgrade-assemblyscript-+-as-pect massalabs/as
3 participants
@AurelienFT @peterjah @Ben-Rey