Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android riscv64 support #11

Closed

Conversation

SiFiveHolland
Copy link

These changes allow building LLVM, including AMDGPU, for a riscv64 board.

@SiFiveHolland SiFiveHolland changed the title riscv64 support Android riscv64 support Jun 16, 2023
@maurossi
Copy link
Owner

Hi, sorry for very late response

In this repo I don't process Pull Request, because I use it as my development repo and not as an upstream repo, also due to my hack approach "DO NOT MERGE: android: translate soong build rules for libLLVM18"

I have tested the build with your proposed change and it can build, but only with Android 14 and later where android_riscv64: property is supported.

I don't know how to implement a conditional rule based on Android version in Android.bp, therefore these changes will have to stay out-of-this-tree, because I am using it to build Android 11, 12, 13

As a side note llvm-project is still using __riscv__ as preprocessor definition

maurossi@ej-desktop:~/u-x86_michael_ax86/external/llvm-project$ cgrep __riscv__
./compiler-rt/lib/fuzzer/FuzzerTracePC.cpp:138:#elif defined(__riscv__)

@maurossi maurossi closed this Aug 15, 2024
@SiFiveHolland
Copy link
Author

Alright, thanks for the explanation. It's no problem. I just wanted these changes to be available in case they were useful to others, and your repository had some visibility on the mesa issue tracker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants