Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BinSkim errors #90

Open
jessamp opened this issue Apr 2, 2022 · 4 comments
Open

Fix BinSkim errors #90

jessamp opened this issue Apr 2, 2022 · 4 comments

Comments

@jessamp
Copy link

jessamp commented Apr 2, 2022

Hi, I have a request to fix the BinSkim errors with hermes. Looks like you'll need to change build flags to disable MD5 hashing and re-enable warnings 4146;4244;4267. When I run the task in our build pipeline, here's what binskim is showing us:

`hermes.dll: error BA2004: 'hermes.dll' is a native binary that directly compiles and links one or more object files which were hashed using an insecure checksum algorithm (MD5). MD5 is subject to collision attacks and its use can compromise supply chain integrity. Pass '/ZH:SHA_256' on the cl.exe command-line to enable secure source code hashing.

hermes.dll: error BA2007: 'hermes.dll' disables compiler warning(s) which are required by policy. A compiler warning is typically required if it has a high likelihood of flagging memory corruption, information disclosure, or double-free vulnerabilities. To resolve this issue, enable the indicated warning(s)`

@ghost ghost added the Needs: triage 🔍 label Apr 2, 2022
@mganandraj
Copy link

Hi @jessamp, do you still need this to be looked at ?

@jessamp
Copy link
Author

jessamp commented Sep 19, 2022

@mganandraj yes. We've worked around this by ignoring this error for now, but would prefer if the errors were fixed. Thanks!

@mganandraj
Copy link

Tudor checked in the following fix a while back to fix the object file checksum.
bcda87c

but the compiler warnings are yet to be enabled.

@slobo80
Copy link

slobo80 commented Feb 7, 2023

We also need this fix. Please prioritize if you can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants