Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native REPL wrongly caches state from previous session #24359

Open
cbrnr opened this issue Oct 30, 2024 · 3 comments
Open

Native REPL wrongly caches state from previous session #24359

cbrnr opened this issue Oct 30, 2024 · 3 comments
Assignees
Labels
area-repl bug Issue identified by VS Code Team member as probable bug needs PR Ready to be worked on

Comments

@cbrnr
Copy link

cbrnr commented Oct 30, 2024

I'm not sure if I'm missing something, but I cannot find an option to restart the native REPL. If I just close the pane and then send another Python statement (Shift-Enter), it gets executed in the previously started native REPL (i.e., all created object in that session will still be available).

@cbrnr cbrnr added the feature-request Request for new features or functionality label Oct 30, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Oct 30, 2024
@anthonykim1
Copy link

Interesting, I can't seem to repro this.
If you close the REPL tab via clicking on the x icon, It should launch new REPL for you when you try to send command again.
Could you try "Python Clear cache and reload" and see if that helps?
Also make sure it says "Python REPL" on the top right corner.

Here is what happens for me on the latest version of vscode insider and python extension.

Screen.Recording.2024-10-31.at.2.13.40.PM.mov

@anthonykim1 anthonykim1 added bug Issue identified by VS Code Team member as probable bug area-repl and removed feature-request Request for new features or functionality triage-needed Needs assignment to the proper sub-team labels Oct 31, 2024
@github-actions github-actions bot added the info-needed Issue requires more information from poster label Oct 31, 2024
@cbrnr
Copy link
Author

cbrnr commented Nov 4, 2024

No, this does not work for me. When I close the Native REPL tab and run a new command, it opens the previous REPL (in this example, x should not exist in a new REPL, but apparently this is still the same session):

Screen.Recording.2024-11-04.at.15.41.22.mov

When I run "Python: Clear Cache and Reload Window", the native REPL session is indeed closed and a new one is started. However, I don't think this is intended, as the REPL should either close when closing the tab or when selecting a dedicated "Trash" action (which does not exist, but this is how the integrated terminal works, so I think the native REPL should behave similarly).

@anthonykim1 anthonykim1 changed the title Add option to restart native REPL Native REPL wrongly caches state from previous session Dec 10, 2024
@anthonykim1
Copy link

Hey @cbrnr Thanks for this, you are 100% correct.
Will make sure this eventually gets resolved, I think this is very important.

@anthonykim1 anthonykim1 added needs PR Ready to be worked on and removed info-needed Issue requires more information from poster labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-repl bug Issue identified by VS Code Team member as probable bug needs PR Ready to be worked on
Projects
None yet
Development

No branches or pull requests

2 participants