Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the originating conversion in the MappedEdits #238449

Open
aeschli opened this issue Jan 22, 2025 · 1 comment
Open

Provide the originating conversion in the MappedEdits #238449

aeschli opened this issue Jan 22, 2025 · 1 comment
Assignees
Labels

Comments

@aeschli
Copy link
Contributor

aeschli commented Jan 22, 2025

We never used the conversation in our mapper code. It turned out that the code block with just the markdown before the block as well as the input file works well.

Would it be good enough to add the ChatResult from the response that contained the block?

Maybe lets open a new feature request so we can discuss this.

Originally posted by @aeschli in 4f2c166

@c-claeys
Copy link
Contributor

Would it be good enough to add the ChatResult from the response that contained the block?

This would be sufficient for us. We need to pass data back and forth from our extension to the chat. Generally, the ChatResult.metadata has been a solid avenue for this. The ChatResult from the response containing such a block makes sense semantically IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants