Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Helm chart or Dockerfile with the option to run varnishnsca for full logs #63

Open
spielkind opened this issue Mar 5, 2021 · 3 comments
Labels
enhancement New feature or request help-wanted Extra attention is needed

Comments

@spielkind
Copy link
Contributor

Either run supervisord as Docker entry, to start varnishnsca:
Example:
https://github.com/globalgiving/docker-varnish-logging

Or better run varnishnsca via sidecar as Option in the Helm chart.

@spielkind spielkind added the enhancement New feature or request label Mar 5, 2021
@martin-helmich
Copy link
Member

I'm not particularly fond of using process managers like supervisord to host multiple services in the same container. In general, I think a sidecar container would be preferable (even though in this case, the sidecar would need to have access to Varnish's shared memory segment -- and I'm not sure how well that would work out. We've had earlier discussions about that btw, for example in #8).

@martin-helmich martin-helmich added the help-wanted Extra attention is needed label Mar 8, 2021
@kmcrawford
Copy link

kmcrawford commented Aug 18, 2023

I have this working, by using the extraContainers, wouldn't be too hard of a stretch to add this to the chart with config to enable/disable and allow for logFormat to be overridden.

extraContainers:
  - name: varnishncsa
    image: quay.io/mittwald/kube-httpcache:stable
    command: ["/bin/sh", "-c", "sleep 10 && varnishncsa -F '%{Host}i %h %l %u %t \"%r\" %s %b \"%{Varnish:handling}x\" \"%{Referer}i\" \"%{User-agent}i\"'"]
    volumeMounts:
      - name: var
        mountPath: /var/lib/varnish

@pserrano
Copy link

Hello,
Is there an estimated timeline for this to be reviewed? Additionally, I am interested in adding Fluentbit/opensearch/ELK support. I’m happy to create a separate PR for that if needed, but it seems like this PR hasn't been checked by any maintainers yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help-wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants