generateDesign ignores fun argument when augmenting(?)

[mb706]

Not sure, but this looks like a bug -- it should probably call fun instead of randomLHS?

[jakob-r]

I already came across this line and decided that it is probably a deliberate decision.
This is only called if points got deleted because they do not fulfill the requirements.
Also there is a specific augmentation strategy in lhs which also don't use here.

Also this is documented here:

ParamHelpers/R/generateDesign.R

Lines 41 to 46 in c2d989c

	#' Note that augmenting currently is somewhat experimental as we simply generate
	#' missing points via new calls to [lhs::randomLHS()], but do not add points so
	#' they are maximally far away from the already present ones. The reason is that
	#' the latter is quite hard to achieve with complicated dependencies and
	#' forbidden regions, if one wants to ensure that points actually get added...
	#' But we are working on it.

Well, the last sentence is a blatant lie 😆

So I would say it's not really a bug. What is your opinion?
I would just leave it like that and close this issue if you agree.

[mb706]

I'm wondering why fun shouldn't just be called a second time. Does it not work with the other lhs::-functions? I'm thinking a user may want to have some biased sampling or call a custom function for some other reason, and would then be annoyed that his function doesn't get called again when augmenting.

[jakob-r]

Feel free to change it 🙂 Maybe the original author wants to have a word @berndbischl 😉