Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

AddressBook: hosts.txt overwritten as a blank file #1006

Closed
coneiric opened this issue Aug 26, 2018 · 3 comments
Closed

AddressBook: hosts.txt overwritten as a blank file #1006

coneiric opened this issue Aug 26, 2018 · 3 comments

Comments

@coneiric
Copy link
Contributor

When downloading a subscription from the default publisher, the default hosts.txt file is overwritten with a blank file.

Until GPG verification is implemented, it is not safe to overwrite the default hosts.txt file, and it should be read-only.


By submitting this issue, I confirm the following:

  • I have read and understood the developer guide in kovri-docs.
  • I have checked that the issue I am reporting can be replicated or that the feature I am suggesting is not present.
  • I have checked opened or recently closed pull requests for existing solutions/implementations to my issue/suggestion.

@anonimal
Copy link
Collaborator

anonimal commented Sep 6, 2018

Until GPG verification is implemented, it is not safe to overwrite the default hosts.txt file, and it should be read-only.

  1. As I've said to you several times already, there is no plan to implement any PGP verification.
  2. It should not be read-only until other subscription work is finished. Our only subscription file needs to be appropriately updated.

Note: the fix is much simpler than #1007.

@coneiric
Copy link
Contributor Author

coneiric commented Sep 6, 2018

As I've said to you several times already, there is no plan to implement any PGP verification

I only remember talking about this once before, apologies for not remembering that point of the conversation. Thought the intention of signing hosts.txt file was to verify it.

It should not be read-only until other subscription work is finished

That's fine, I can just overwrite with the newly downloaded hosts.txt, and not worry about PGP verification.

@anonimal
Copy link
Collaborator

anonimal commented Sep 7, 2018

NOTICE: THIS ISSUE HAS BEEN MOVED TO GitLab. Please continue the discussion there. See #1013 for details.

@anonimal anonimal closed this as completed Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants