Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

page_service: pagestream_do_batch: abstract & dedup merging logic #10433

Open
problame opened this issue Jan 16, 2025 · 0 comments
Open

page_service: pagestream_do_batch: abstract & dedup merging logic #10433

problame opened this issue Jan 16, 2025 · 0 comments

Comments

@problame
Copy link
Contributor

problame commented Jan 16, 2025 •
edited
Loading 

          nit: would be nice to lift this somehow and reduce duplication with the above

Originally posted by @VladLazar in #10386 (comment)

problame 1 minute ago
Hm, tricky. I guess the commonality for all things batching right now is that we dispatch to one shard, and there's the notion of a batching key that if it doesn't match causes batching to stop and start anew.

I don't want to clean it up in this PR because it needs to test in staging and ship tomorrow.

But I'll create a follow-up ticket
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@problame