Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep openapi.json in git #10560

Open
kesselb opened this issue Jan 13, 2025 · 4 comments
Open

Keep openapi.json in git #10560

kesselb opened this issue Jan 13, 2025 · 4 comments
Labels
0. to triage enhancement

Comments

@kesselb
Copy link
Contributor

kesselb commented Jan 13, 2025

Is your feature request related to a problem? Please describe.

As other apps do.

We have a workflow to ensure the file is up-to-date.

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response
@ChristophWurst
Copy link
Member

I would argue against this, just for the maintenance burden. If a developer needs the json file for a specific version, they can generate it. For releases we can include the file in the .tar.gz, if not included already.

@kesselb
Copy link
Contributor Author

kesselb commented Jan 14, 2025

@marcelklehr would that work as well?

@marcelklehr
Copy link
Member

Sure, that works as well

@ChristophWurst
Copy link
Member

It should already be part of releases:

mail/krankerl.toml

Line 8 in b65e90e

"composer openapi"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0. to triage enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marcelklehr @ChristophWurst @kesselb