Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@nx/storybook/plugin should use its own executor in non-angular cases #29706

Closed
1 of 4 tasks
comp615 opened this issue Jan 21, 2025 · 1 comment
Closed
1 of 4 tasks

@nx/storybook/plugin should use its own executor in non-angular cases #29706

comp615 opened this issue Jan 21, 2025 · 1 comment

Comments

@comp615
Copy link

comp615 commented Jan 21, 2025

Current Behavior

Currently, the @nx/storybook package provides executors for building and serving storybook.

However, when one uses the @nx/storybook/plugin to generate inferred tasks, unless the angular framework is detected, these tasks are generated running the storybook CLI directly.

Code Reference

Expected Behavior

The plugin should reference its own executor when creating the tasks, this would provide more consistency and flexibility between the angular and standard implementation, as well as CLI/options compatibility. Currently it's very confusing to decide if we want the provided executor or the inferred tasks since they are mutually exclusive (it's impossible to merge a different executor over the inferred task in NX by design)

GitHub Repo

No response

Steps to Reproduce

  1. Open a storybook based package
  2. run nx show project
  3. Observe the chosen executor

Nx Report

Node           : 22.9.0
OS             : darwin-arm64
Native Target  : aarch64-macos
pnpm           : 9.11.0

nx                 : 20.0.1
@nx/js             : 20.0.1
@nx/jest           : 20.0.1
@nx/eslint         : 20.0.1
@nx/workspace      : 20.0.1
@nx/cypress        : 20.0.1
@nx/devkit         : 20.0.1
@nx/eslint-plugin  : 20.0.1
@nx/plugin         : 20.0.1
@nx/react          : 20.0.1
@nx/storybook      : 20.0.1
@nx/vite           : 20.0.1
@nx/web            : 20.0.1
typescript         : 5.5.4
---------------------------------------
Registered Plugins:
@nx/vite/plugin
@nx/storybook/plugin

Failure Logs

Package Manager Version

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

No response

@AgentEnder
Copy link
Member

This is intended - inferred tasks prefer raw commands if possible to make things easier to configure for folks that are more familiar with the tool (storybook in this case) and less familiar with Nx. This is a bit of a weird area where it is possible to use the command for almost all of them, but the angular case isn't quite ready yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants