Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headings in hero mode don't follow the color scheme switch (dark|light) #1911

Open
simonedimaria opened this issue Jan 12, 2025 · 0 comments

Comments

@simonedimaria
Copy link

Describe the bug
Headings in hero mode don't follow the color scheme switch (dark|light)

Hugo & Blowfish versions
Blowfish version: 2.81.0, Hugo version: hugo v0.140.2+extended linux/amd64 BuildDate=unknown

Additional context
The issue relies on the color being hardcoded in the hero.html partial here. The above lines for Author name have also hardcoded color but i think it's fine since it should contrast the user-supplied hero image. While for the heading, the headline being markdownified, if it's e.g. a code block, the text will be sorrounded by a background color that follows the color scheme (dark|light), thus becoming unreadable in light mode since the hardcoded value for the text is currently light in color.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant