Organization logo is barely visible in gh dark mode

[hichemfantar]

the logo should have a white background to look good on both light and dark mode

[ljharb]

ah, I never use dark mode, so I've never ran into it.

I don't actually have a logo that's not transparent available - tbh this seems like a GitHub bug; they should probably keep the background of images white in dark mode.

That said, I'll certainly give it a shot next time I'm at a computer.

[hichemfantar]

It's not a github bug as transparent logos should only be used when you have control of how they're displayed which means in this case you have provide it with a background to make sure the logo looks correct no matter who where it's displayed.

examples
actix/actix-website#385
elixir-lang/elixir#14197

[ljharb]

That’s true when designing a website, but GitHub’s worked with transparent logos for over 15 years, so them adding dark mode should have been coupled with ensuring image backgrounds remain white.