Warn of the dangers of malicious text #262
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awoie
approved these changes
Oct 8, 2024
|
Applies to claims as well (everything, really). JSON Schema might be malicious as well (e.g., via a regex). |
|
the rat hole is deep ... |
Sakurann
approved these changes
Oct 15, 2024
Or be sufficently clear that we are just scratching the surface and not even trying to be comprehensive. |
awoie
reviewed
Dec 3, 2024
Comment on lines
+1095
to
+1110
| ## Risks Associated with Displaying Textual Information {#risks-displaying-textual-information} | ||
|
|
||
| The `display` property in the Type Metadata allows providers of metadata to | ||
| specify human-readable labels and descriptions for claims. Likewise, `name` and | ||
| `description` can contain arbitrary textual information that may be displayed to | ||
| developers. As such, any consuming application MUST ensure that maliciously | ||
| crafted information cannot be used to compromise the security of the application | ||
| or the privacy of the user. To this end, the following considerations apply: | ||
|
|
||
| - The consuming application MUST ensure that the text is properly escaped before | ||
| displaying it to the user or transferring it into other contexts. For example, | ||
| if the data is displayed in an HTML document, the text MUST be properly | ||
| escaped to prevent Cross-Site Scripting (XSS) attacks. | ||
| - The consuming application MUST ensure that the display of the user interface | ||
| elements cannot be distorted by overly long text or special characters. | ||
|
|
There was a problem hiding this comment.
Suggested change
| ## Risks Associated with Displaying Textual Information {#risks-displaying-textual-information} | |
| The `display` property in the Type Metadata allows providers of metadata to | |
| specify human-readable labels and descriptions for claims. Likewise, `name` and | |
| `description` can contain arbitrary textual information that may be displayed to | |
| developers. As such, any consuming application MUST ensure that maliciously | |
| crafted information cannot be used to compromise the security of the application | |
| or the privacy of the user. To this end, the following considerations apply: | |
| - The consuming application MUST ensure that the text is properly escaped before | |
| displaying it to the user or transferring it into other contexts. For example, | |
| if the data is displayed in an HTML document, the text MUST be properly | |
| escaped to prevent Cross-Site Scripting (XSS) attacks. | |
| - The consuming application MUST ensure that the display of the user interface | |
| elements cannot be distorted by overly long text or special characters. | |
| ## Risks Associated with Textual Information {#risks-textual-information} | |
| Some claims in the SD-JWT VC and properties in the Type Metadata, e.g., `display`, allows issuers and providers of metadata to | |
| specify human-readable information. These can contain arbitrary textual information that | |
| may be displayed to developers. As such, any consuming application MUST ensure that maliciously | |
| crafted information cannot be used to compromise the security of the application | |
| or the privacy of the user. To this end, the following considerations apply: | |
| - The consuming application MUST ensure that the text is properly escaped before | |
| displaying it to the user or transferring it into other contexts. For example, | |
| if the data is displayed in an HTML document, the text MUST be properly | |
| escaped to prevent Cross-Site Scripting (XSS) attacks. | |
| - The consuming application MUST ensure that the display of the user interface | |
| elements cannot be distorted by overly long text or special characters. |
I tried to make suggestions to this PR to make it more general. This would be another option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #259