Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use official dark/light visuals as org banner instead of custom-made image #4

Open
benoit74 opened this issue Sep 2, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@benoit74
Copy link

benoit74 commented Sep 2, 2024

Currently the org banner at https://github.com/offspot/.github/blob/main/profile/README.md is a custom-made image which is not part of the official visuals.

Since Github is perfectly supporting dark/light picture in markdown for some time, we should probably give it a try to use official logos:

<picture>
  <source media="(prefers-color-scheme: dark)" srcset="./dark.png">
  <img alt="Text changing depending on mode. Light: 'So light!' Dark: 'So dark!'" src="./light.png">
</picture>

Or we could even directly use the SVG which embeds this dark/light code.

Or do I miss something?

@benoit74 benoit74 added the enhancement New feature or request label Sep 2, 2024
@rgaudin
Copy link
Member

rgaudin commented Sep 2, 2024

You're right. Not sure if GH supports the themed SVG in README (it doesn't in issues) but otherwise using both PNGs as suggested would work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants