Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify syntax for variables in CSV inputs #11

Open
sarathms opened this issue Oct 3, 2019 · 1 comment
Open

Unify syntax for variables in CSV inputs #11

sarathms opened this issue Oct 3, 2019 · 1 comment
Labels
discuss invites discussion from contributors question Further information is requested

Comments

@sarathms
Copy link
Contributor

sarathms commented Oct 3, 2019

We use react-intl in our web projects which expects source strings to use {} to declare variables. e.g "This is a {variable}"

For mobile projects, we follow a slightly different syntax ("This is a {{variable}}"). This prevents us from reusing strings from the mobile projects in say probe-desktop where we want to achieve very close resemblance.

If the syntax used the mobile copy, isn't coupled with a 3rd party dependency package, maybe we can start using the {variable} format for all projects across the board. I am guessing this just needs changes to the json-to-android-xml.py script.

cc: @hellais @lorenzoPrimi

@sarathms sarathms added the question Further information is requested label Oct 3, 2019
@lorenzoPrimi
Copy link
Contributor

Native Android and iOS app can't use {variable} natively, there can be a third part library but I won't rely on that.

@hellais hellais added the discuss invites discussion from contributors label Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss invites discussion from contributors question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants