Add Instrument.keywords value for GMOS-N/S #12
Comments
dbohlender
changed the title
|
Actually, at 3AM I realized that the jsonsummary 'mode' value is likely sufficient for this. It is supposed to provide values of "imaging, spectroscopy, LS (Longslit Spectroscopy), MOS (Multi Object Spectroscopy) or IFS (Integral Field Spectroscopy)". There is likely no reason to change these values but simply use them for the value of Instrument.keywords. |
SharonGoliath
added a commit
that referenced
this issue
Aug 28, 2020
* s2627 - handle a few more naming patterns during validation. * t76247 - initial testing with proposed Gemini incremental harvesting URL. * s2646 - regression testing. * s2646 - refactor Gemini to make use of the run_composable, name_builder_composable, and data_source_composable abstractions introduced into caom2pipe. * s2647 - regression testing cleanup. * Remove spurious directory commit. * s2648 - regression testing for OMM. * s2648 - regression testing for OMM. * s2648 - regression testing for OMM. * s2648 - regression testing for OMM. * s2648 - regression testing for OMM. * s2468 - SITELLE regression testing. * s2650 - SPIRou regression testing. * s2650 - SPIRou regression testing. * s2650 - SPIRou regression testing - add importlib-metadata to Dockerfile. * Issue #4 - add CachingObsFileRelationship class to do a lookup of the observationID<=>file name relationship that is ordered by distance from execution. * Issue #3 - fix provenance handling. * Issue #3 - integration testing. * Issue #6 - replace execute_composable invocations with run_composable invocations. Refactor how file name to data label lookup is handled. * Issue #6 - replace execute_composable invocations with run_composable invocations. * Issue #6 - use all caom2tools from github. * Issue #6 - fix how recently public query handles netrc file authentication and authorization. * Issue #6 - got side-tracked and fixed (?) the WCS validation issue with the caom2.4 validator. * Issue #6 - header information from archive.gemini.edu may contain '--- PHU' OR '--- HDU 0'. * s2748 - do an initial test observation for ZORRO/ALOPEKE, and rename the expected xml files. * s2748 + #5 - some fixes. * s2748 - setting the cache for a file lookup. * Issue #5 - rethinking the way command-line arguments are issued. * Issue #5 - remove a lot of code that was used when processing was by observationID/data label. It's no longer required now that processing is by file name. * Issue #5 - more cleanup of code that's no longer required. * Issue #5 - scrape help. * s2766 - OBJECT file spatial WCS refactoring. * s2766 - make changes for s2770 available sooner. * Update setup.cfg * s2770 - GEMINI. * Issue #12 - GMOS keywords should be associated with instrument, not provenance. Co-authored-by: Sharon Goliath <[email protected]>
SharonGoliath
added a commit
that referenced
this issue
Sep 3, 2020
* s2627 - handle a few more naming patterns during validation. * t76247 - initial testing with proposed Gemini incremental harvesting URL. * s2646 - regression testing. * s2646 - refactor Gemini to make use of the run_composable, name_builder_composable, and data_source_composable abstractions introduced into caom2pipe. * s2647 - regression testing cleanup. * Remove spurious directory commit. * s2648 - regression testing for OMM. * s2648 - regression testing for OMM. * s2648 - regression testing for OMM. * s2648 - regression testing for OMM. * s2648 - regression testing for OMM. * s2468 - SITELLE regression testing. * s2650 - SPIRou regression testing. * s2650 - SPIRou regression testing. * s2650 - SPIRou regression testing - add importlib-metadata to Dockerfile. * Issue #4 - add CachingObsFileRelationship class to do a lookup of the observationID<=>file name relationship that is ordered by distance from execution. * Issue #3 - fix provenance handling. * Issue #3 - integration testing. * Issue #6 - replace execute_composable invocations with run_composable invocations. Refactor how file name to data label lookup is handled. * Issue #6 - replace execute_composable invocations with run_composable invocations. * Issue #6 - use all caom2tools from github. * Issue #6 - fix how recently public query handles netrc file authentication and authorization. * Issue #6 - got side-tracked and fixed (?) the WCS validation issue with the caom2.4 validator. * Issue #6 - header information from archive.gemini.edu may contain '--- PHU' OR '--- HDU 0'. * s2748 - do an initial test observation for ZORRO/ALOPEKE, and rename the expected xml files. * s2748 + #5 - some fixes. * s2748 - setting the cache for a file lookup. * Issue #5 - rethinking the way command-line arguments are issued. * Issue #5 - remove a lot of code that was used when processing was by observationID/data label. It's no longer required now that processing is by file name. * Issue #5 - more cleanup of code that's no longer required. * Issue #5 - scrape help. * s2766 - OBJECT file spatial WCS refactoring. * s2766 - make changes for s2770 available sooner. * Update setup.cfg * s2770 - GEMINI. * Issue #12 - GMOS keywords should be associated with instrument, not provenance. * Issue #5 - files with no prefix do not have 'fixed' data labels. * s2748 - Add support for ALOPEKE/ZORRO observationID handling to GemName. * s2748 - initial attempt at ALOPEKE observation. * s2748 - Alopeke - 2 planes per set of files. * s2748 - Add ZORRO test records. * s2766 - side-effects of consistent keyword handling in fits2caom2. * s2748 - add calibration files to Alopeke/Zorro test set. Co-authored-by: Sharon Goliath <[email protected]>
SharonGoliath
added a commit
that referenced
this issue
Sep 8, 2020
* s2627 - handle a few more naming patterns during validation. * t76247 - initial testing with proposed Gemini incremental harvesting URL. * s2646 - regression testing. * s2646 - refactor Gemini to make use of the run_composable, name_builder_composable, and data_source_composable abstractions introduced into caom2pipe. * s2647 - regression testing cleanup. * Remove spurious directory commit. * s2648 - regression testing for OMM. * s2648 - regression testing for OMM. * s2648 - regression testing for OMM. * s2648 - regression testing for OMM. * s2648 - regression testing for OMM. * s2468 - SITELLE regression testing. * s2650 - SPIRou regression testing. * s2650 - SPIRou regression testing. * s2650 - SPIRou regression testing - add importlib-metadata to Dockerfile. * Issue #4 - add CachingObsFileRelationship class to do a lookup of the observationID<=>file name relationship that is ordered by distance from execution. * Issue #3 - fix provenance handling. * Issue #3 - integration testing. * Issue #6 - replace execute_composable invocations with run_composable invocations. Refactor how file name to data label lookup is handled. * Issue #6 - replace execute_composable invocations with run_composable invocations. * Issue #6 - use all caom2tools from github. * Issue #6 - fix how recently public query handles netrc file authentication and authorization. * Issue #6 - got side-tracked and fixed (?) the WCS validation issue with the caom2.4 validator. * Issue #6 - header information from archive.gemini.edu may contain '--- PHU' OR '--- HDU 0'. * s2748 - do an initial test observation for ZORRO/ALOPEKE, and rename the expected xml files. * s2748 + #5 - some fixes. * s2748 - setting the cache for a file lookup. * Issue #5 - rethinking the way command-line arguments are issued. * Issue #5 - remove a lot of code that was used when processing was by observationID/data label. It's no longer required now that processing is by file name. * Issue #5 - more cleanup of code that's no longer required. * Issue #5 - scrape help. * s2766 - OBJECT file spatial WCS refactoring. * s2766 - make changes for s2770 available sooner. * Update setup.cfg * s2770 - GEMINI. * Issue #12 - GMOS keywords should be associated with instrument, not provenance. * Issue #5 - files with no prefix do not have 'fixed' data labels. * s2748 - Add support for ALOPEKE/ZORRO observationID handling to GemName. * s2748 - initial attempt at ALOPEKE observation. * s2748 - Alopeke - 2 planes per set of files. * s2748 - Add ZORRO test records. * s2766 - side-effects of consistent keyword handling in fits2caom2. * s2748 - add calibration files to Alopeke/Zorro test set. * s2748 - fix attribute name in config reference. * s2748 - regression testing - get scrape + modify to work with preview generation. Co-authored-by: Sharon Goliath <[email protected]>
SharonGoliath
added a commit
that referenced
this issue
Sep 9, 2020
* s2627 - handle a few more naming patterns during validation. * t76247 - initial testing with proposed Gemini incremental harvesting URL. * s2646 - regression testing. * s2646 - refactor Gemini to make use of the run_composable, name_builder_composable, and data_source_composable abstractions introduced into caom2pipe. * s2647 - regression testing cleanup. * Remove spurious directory commit. * s2648 - regression testing for OMM. * s2648 - regression testing for OMM. * s2648 - regression testing for OMM. * s2648 - regression testing for OMM. * s2648 - regression testing for OMM. * s2468 - SITELLE regression testing. * s2650 - SPIRou regression testing. * s2650 - SPIRou regression testing. * s2650 - SPIRou regression testing - add importlib-metadata to Dockerfile. * Issue #4 - add CachingObsFileRelationship class to do a lookup of the observationID<=>file name relationship that is ordered by distance from execution. * Issue #3 - fix provenance handling. * Issue #3 - integration testing. * Issue #6 - replace execute_composable invocations with run_composable invocations. Refactor how file name to data label lookup is handled. * Issue #6 - replace execute_composable invocations with run_composable invocations. * Issue #6 - use all caom2tools from github. * Issue #6 - fix how recently public query handles netrc file authentication and authorization. * Issue #6 - got side-tracked and fixed (?) the WCS validation issue with the caom2.4 validator. * Issue #6 - header information from archive.gemini.edu may contain '--- PHU' OR '--- HDU 0'. * s2748 - do an initial test observation for ZORRO/ALOPEKE, and rename the expected xml files. * s2748 + #5 - some fixes. * s2748 - setting the cache for a file lookup. * Issue #5 - rethinking the way command-line arguments are issued. * Issue #5 - remove a lot of code that was used when processing was by observationID/data label. It's no longer required now that processing is by file name. * Issue #5 - more cleanup of code that's no longer required. * Issue #5 - scrape help. * s2766 - OBJECT file spatial WCS refactoring. * s2766 - make changes for s2770 available sooner. * Update setup.cfg * s2770 - GEMINI. * Issue #12 - GMOS keywords should be associated with instrument, not provenance. * Issue #5 - files with no prefix do not have 'fixed' data labels. * s2748 - Add support for ALOPEKE/ZORRO observationID handling to GemName. * s2748 - initial attempt at ALOPEKE observation. * s2748 - Alopeke - 2 planes per set of files. * s2748 - Add ZORRO test records. * s2766 - side-effects of consistent keyword handling in fits2caom2. * s2748 - add calibration files to Alopeke/Zorro test set. * s2748 - fix attribute name in config reference. * s2748 - regression testing - get scrape + modify to work with preview generation. Co-authored-by: Sharon Goliath <[email protected]>
SharonGoliath
added a commit
that referenced
this issue
Oct 27, 2020
* s2627 - handle a few more naming patterns during validation. * t76247 - initial testing with proposed Gemini incremental harvesting URL. * s2646 - regression testing. * s2646 - refactor Gemini to make use of the run_composable, name_builder_composable, and data_source_composable abstractions introduced into caom2pipe. * s2647 - regression testing cleanup. * Remove spurious directory commit. * s2648 - regression testing for OMM. * s2648 - regression testing for OMM. * s2648 - regression testing for OMM. * s2648 - regression testing for OMM. * s2648 - regression testing for OMM. * s2468 - SITELLE regression testing. * s2650 - SPIRou regression testing. * s2650 - SPIRou regression testing. * s2650 - SPIRou regression testing - add importlib-metadata to Dockerfile. * Issue #4 - add CachingObsFileRelationship class to do a lookup of the observationID<=>file name relationship that is ordered by distance from execution. * Issue #3 - fix provenance handling. * Issue #3 - integration testing. * Issue #6 - replace execute_composable invocations with run_composable invocations. Refactor how file name to data label lookup is handled. * Issue #6 - replace execute_composable invocations with run_composable invocations. * Issue #6 - use all caom2tools from github. * Issue #6 - fix how recently public query handles netrc file authentication and authorization. * Issue #6 - got side-tracked and fixed (?) the WCS validation issue with the caom2.4 validator. * Issue #6 - header information from archive.gemini.edu may contain '--- PHU' OR '--- HDU 0'. * s2748 - do an initial test observation for ZORRO/ALOPEKE, and rename the expected xml files. * s2748 + #5 - some fixes. * s2748 - setting the cache for a file lookup. * Issue #5 - rethinking the way command-line arguments are issued. * Issue #5 - remove a lot of code that was used when processing was by observationID/data label. It's no longer required now that processing is by file name. * Issue #5 - more cleanup of code that's no longer required. * Issue #5 - scrape help. * s2766 - OBJECT file spatial WCS refactoring. * s2766 - make changes for s2770 available sooner. * Update setup.cfg * s2770 - GEMINI. * Issue #12 - GMOS keywords should be associated with instrument, not provenance. * Issue #5 - files with no prefix do not have 'fixed' data labels. * s2748 - Add support for ALOPEKE/ZORRO observationID handling to GemName. * s2748 - initial attempt at ALOPEKE observation. * s2748 - Alopeke - 2 planes per set of files. * s2748 - Add ZORRO test records. * s2766 - side-effects of consistent keyword handling in fits2caom2. * s2748 - add calibration files to Alopeke/Zorro test set. * s2748 - fix attribute name in config reference. * s2748 - regression testing - get scrape + modify to work with preview generation. * caom2pipe refactoring - remove work.py and it's dependencies, refactor composable.py. * ZORRO - files without a third axis. * GEMINI Dockerfile changes - move from opencadc-metadata-curation to opencadc. Co-authored-by: Sharon Goliath <[email protected]>
SharonGoliath
added a commit
to SharonGoliath/gem2caom2
that referenced
this issue
Jan 7, 2021
…t, not provenance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently there is no CAOM2 metadata that enables a user to distinguish different spectroscopic modes of GMOS-N/S data. e.g. long-slit vs. IFU vs. MOS (multi-object spectroscopy).
To enable this with at least a TAP query it would be useful to modify the gem2caom2 code to add an Instrument.keywords value for GMOS-N/S spectra. The instrument mode can be identified by the value of the MASKNAME FITS header keyword or the jsonsummary's focal_plane_mask value:
Assuming that Plane.dataProductType has already been determined then:
If Plane. dataProductType = spectrum:
If MASKNAME/focal_plane_mask contains string 'arcsec' then Instrument.keywords = long-slit
elIf MASKNAME/focal_plane_mask contains the string 'IFU' then Instrument.keywords = IFU
else any other spectra should have Instrument.keywords = MOS
else:
Instrument.keywords = imaging
The text was updated successfully, but these errors were encountered: