Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Clarify meaning of term suggester's suggest_mode "missing" #9039

Open
1 task done
snikoyo opened this issue Jan 9, 2025 · 4 comments
Open
1 task done

[DOC] Clarify meaning of term suggester's suggest_mode "missing" #9039

snikoyo opened this issue Jan 9, 2025 · 4 comments

Comments

@snikoyo
Copy link

snikoyo commented Jan 9, 2025

What do you want to do?

  • Request a change to existing documentation

The page "Did You Mean" states the meaning of the term suggester's suggest_mode parameter as follows:

The suggest mode specifies the terms for which suggestions should be included in the response. Valid values are:

  • missing: Return suggestions only for the input text terms that are not in the index.

"not in the index" is not exact enough. The missing mode is field specific: It will only suggest those terms that have zero occurrences in the given field of the index. This is a huge difference in most practical applications. In fact, it would be a huge improvement of the term suggester if there was a mode that would consider the complete index to find out if a term is missing or not.

Version: all

@Naarcha-AWS
Copy link
Collaborator

@snikoyo: This sounds like both a documentation change and a potential piece of feedback for the Term suggester behavior. Do we need to make an issue in the Core or Search Plugin repos as well?

@snikoyo
Copy link
Author

snikoyo commented Jan 16, 2025

@Naarcha-AWS It would be very helpful to change the term suggester so that it considers the complete index and not only the field. I could imagine that this would better match the spell check use cases of most users. I guess that many have implemented a workaround using a copyTo field.

@snikoyo
Copy link
Author

snikoyo commented Jan 16, 2025

Instead of changing the behaviour of the "MISSING" mode, it could just be an additional mode like "MISSING_INDEX".

@krisfreedain
Copy link
Member

Catch All Triage - 1, 2, 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants