Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with Symfony events #143

Open
5 tasks
PVince81 opened this issue Apr 26, 2018 · 3 comments
Open
5 tasks

Issues with Symfony events #143

PVince81 opened this issue Apr 26, 2018 · 3 comments
Labels

Comments

@PVince81
Copy link
Contributor

PVince81 commented Apr 26, 2018

  • "user_displayName" is actually user id, needs to be named accordingly
  • "roleDisaplayName" this typo seems to have infected all layers, please fix in a compatible manner without breaking consumers
  • custom group id is missing in all events. Remember that custom group name is not enough to identify a group
  • sometimes the field is called "groupName" and sometimes "group_displayName"
  • use camel case for all attributes: "userDisplayName" instead of "user_displayName"
@PVince81 PVince81 added the bug label Apr 26, 2018
@PVince81 PVince81 added this to the triage milestone Apr 26, 2018
@PVince81
Copy link
Contributor Author

@sharidas

@PVince81 PVince81 modified the milestones: triage, maybe some day May 22, 2018
@PVince81
Copy link
Contributor Author

PVince81 commented Feb 4, 2019

@sharidas didn't you fix this somewhere already ?

@sharidas
Copy link
Contributor

sharidas commented Feb 5, 2019

Here is one fix #146. This is the only one I find from the commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants