Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] deleting shared files misses details about restore #20

Open
12 tasks
jnweiger opened this issue Apr 4, 2022 · 2 comments
Open
12 tasks

[QA] deleting shared files misses details about restore #20

jnweiger opened this issue Apr 4, 2022 · 2 comments
Assignees

Comments

@jnweiger
Copy link
Contributor

jnweiger commented Apr 4, 2022

In https://github.com/owncloud/docs-webui/edit/master/modules/classic_ui/pages/files/deleted_file_management.adoc
we have a description about trashcans used when deleting shared objects.
This section should also speak about restore.

Holger's workaround to owncloud/core#39945 could be added.
or
My workaround :-) or a general warning.

WHAT Needs to be Documented?

WHERE Does This Need To Be Documented (Link)?

WHY Should This Change Be Made?

(Optional) What Type Of Content Change Is This?

  • New Content Addition
  • Old Content Deprecation
  • Existing Content Simplification
  • Bug Fix to Existing Content

(Optional) Which Manual Does This Relate To?

  • Admin Manual
  • Developer Manual
  • User Manual
  • Android
  • iOS
  • Branded Clients
  • Desktop Client
  • Other
@mmattel
Copy link
Contributor

mmattel commented Apr 4, 2022

Holger's workaround to owncloud/core#39945 could be added.

userA can solve by restoring and then deleting fileid 50 = workaround exists
For me this is good enough IMO

This is an END USER documentation. This kind of info is far, far, far away from end user level... 😵 🤯

@jnweiger
Copy link
Contributor Author

jnweiger commented Apr 4, 2022

info.xml (description, as visible in Marketplace) of files_trashbin says

When a file is deleted from a share, it can be restored in the same manner, though it is no longer shared.

Which is a nice warning, but too negative. We 'sometimes' preserve the sharing info :-)

(Not sure why Holger suggests that userA should tinker in the sharing table. Orphaned database entries are just fine.)
Possible useful wording for documentation:

"When restoring a shared file or folder, sharing information may be lost."

Hint:
In the case of a received share, deleted objects can be restored by both, the share owner and the user who deleted them.
To preserve sharing information, the share owner should do the restore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants