Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Footer: About, Legal, Privacy #46

Closed
sepulzera opened this issue May 26, 2022 · 1 comment
Closed

Improve Footer: About, Legal, Privacy #46

sepulzera opened this issue May 26, 2022 · 1 comment
Assignees
@sepulzera
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
v3.0.0

Comments

@sepulzera
Copy link

sepulzera commented May 26, 2022 •
edited
Loading

Improve the footer to include links to an About page/dialog (internal) and to optionally put links to legal and privacy pages (external).

It should be able to configure the href's of the links for all external pages via env:

  • REACT_APP_LEGAL_URL
  • REACT_APP_PRICACY_URL
@sepulzera sepulzera added enhancement New feature or request good first issue Good for newcomers labels May 26, 2022
@sepulzera sepulzera added this to the v3.0.0 milestone May 26, 2022
@sepulzera sepulzera self-assigned this May 26, 2022
@sepulzera
Copy link
Author

Needs explaination in the docs. Probably as well in the provided env files as comments. (env comments should be supported with node 16.14, but should definitely be tested carefully).

sepulzera added a commit to ownrecipes/ownrecipes-web that referenced this issue Jun 11, 2022
@sepulzera
Improve Footer: About, Legal, Privacy
54eea5b 
(ownrecipes/OwnRecipes#46)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sepulzera sepulzera

Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
v3.0.0
Development

No branches or pull requests
1 participant
@sepulzera