Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play Sprint Plan 2019-07-15 #95

Closed
19 of 26 tasks
dwijnand opened this issue Jul 10, 2019 · 4 comments
Closed
19 of 26 tasks

Play Sprint Plan 2019-07-15 #95

dwijnand opened this issue Jul 10, 2019 · 4 comments

Comments

@dwijnand
Copy link
Member

dwijnand commented Jul 10, 2019


Metadata
  • Dates: 2019-07-15 - 2019-07-26
  • Previous Sprint: Play Sprint Plan 2019-07-01 #89
  • Support Rota: Marcos then Ignasi
  • Person days: 25.5/30
    • Dale off 15-16
    • Ignasi 50%(?) off 15, 100% off 16
    • Renato off on 26
@octonato octonato pinned this issue Jul 12, 2019
@marcospereira
Copy link
Member

I will leave this as a comment so that we can edit the issue next Monday instead:

Scala 2.13:

Java 11

  • Lagom seeds are failing for Java 11 (related to Cassadra). I'm pretty confident that these will be fixed when upgrading to Akka Persistence Cassandra 0.9.x.
  • We still have some projects allowing Java 11 failures in our builds. It could be good to remove these from Travis configuration to track possible regressions better.

@dwijnand
Copy link
Member Author

Proposal: tear the lagom part of play-grpc out of play-grpc and into lagom/lagom (keep it as an incubating module), thus making play's grpc samples not depend on lagom (indirectly).

@marcospereira marcospereira changed the title [DRAFT] Play Sprint Plan 2019-07-15 Play Sprint Plan 2019-07-15 Jul 15, 2019
@octonato
Copy link
Contributor

Locally test seeds after the upgrade to ensure they are not failing when running with Java 11

I tested it manually with a local build and Java 11 and it works, however I got messages like:

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by javassist.util.proxy.SecurityActions (file:/Users/renato/.ivy2/cache/org.javassist/javassist/bundles/javassist-3.24.0-GA.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain)
WARNING: Please consider reporting this to the maintainers of javassist.util.proxy.SecurityActions
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.apache.cassandra.utils.FBUtilities (file:/Users/renato/Sources/tmp/hello-world/target/embedded-cassandra/cassandra-bundle.jar) to field java.io.FileDescriptor.fd
WARNING: Please consider reporting this to the maintainers of org.apache.cassandra.utils.FBUtilities
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

This is not related to Cassandra though.

@marcospereira
Copy link
Member

Well, one of the problems is indeed related to Cassandra:

WARNING: Illegal reflective access by org.apache.cassandra.utils.FBUtilities (file:/Users/renato/Sources/tmp/hello-world/target/embedded-cassandra/cassandra-bundle.jar) to field java.io.FileDescriptor.fd
WARNING: Please consider reporting this to the maintainers of org.apache.cassandra.utils.FBUtilities

But there is nothing we can do right now, and there are other places where dependencies are raising similar warnings. So I think we are good to go here.

@dwijnand dwijnand unpinned this issue Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants