Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: add type hints and py.typed for type checkers and tab complete #4927

Open
jamesbraza opened this issue Dec 4, 2024 · 4 comments
Open
Labels
feature something new P2 considered for next cycle

Comments

@jamesbraza
Copy link

With plotly==5.24.1, running mypy==1.13.0 on a module importing plotly:

error: Cannot find implementation or library stub for module named "plotly.express" [import-not-found]
    import plotly.express as px
    ^

The request is can plotly add type hints, and a py.typed so type checkers can use them?

@gvwilson
Copy link
Contributor

gvwilson commented Dec 4, 2024

Hi @jamesbraza - we have no plans to do this in the near future (lack of resources) but a community PR would be reviewed very quickly if you'd like to tackle it.

@gvwilson gvwilson added feature something new P3 backlog labels Dec 4, 2024
@Caelmap
Copy link

Caelmap commented Jan 15, 2025

Maybe I have not understood something, but isn't pull request #4424 all that is needed to solve this? It would just need approving and adding to a release?

Locally, even just adding an empty py.typed file in the plotly parent folder of my .venv (which is basically what that request does), makes plotly a far nicer dev experience with mypy.

@jamesbraza
Copy link
Author

Hi @Caelmap yes you're right, that PR alone will resolve this

@gvwilson gvwilson added P2 considered for next cycle and removed P3 backlog labels Jan 15, 2025
@gvwilson
Copy link
Contributor

thanks for the discussion everyone - I'll see if we can get this on the roadmap for immediately after the upcoming release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new P2 considered for next cycle
Projects
None yet
Development

No branches or pull requests

3 participants