Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Keep These Display Settings prompt counts 0 as a second #891

Open
opalmay opened this issue Jan 11, 2025 · 4 comments
Open

[BUG] Keep These Display Settings prompt counts 0 as a second #891

opalmay opened this issue Jan 11, 2025 · 4 comments

Comments

@opalmay
Copy link

opalmay commented Jan 11, 2025

screenshot-2025-01-11-12-22-46

@leviport
Copy link
Member

Is your expectation that the revert happens after 1, and 0 is never shown?

@opalmay
Copy link
Author

opalmay commented Jan 14, 2025

Is your expectation that the revert happens after 1, and 0 is never shown?

Yes, that would make sense, wouldn't it?
Right now when it says "revert in x seconds" it actually reverts after x+1 seconds

@leviport
Copy link
Member

I personally don't think so. There is a whole second between 1 and 0, so showing 0 during that time seems natural to me. Disappearing after 1 seems like it would be far more jarring.

@opalmay
Copy link
Author

opalmay commented Jan 17, 2025

I personally don't think so. There is a whole second between 1 and 0, so showing 0 during that time seems natural to me. Disappearing after 1 seems like it would be far more jarring.

I don't mind too much either way, I just noticed and found it odd. I think it should match the way it is in different settings GUIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants