-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processing] Fix feature iteration against a model #60194
base: master
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
/** | ||
* Clears model results previously populated when the context was used to run a model algorithm. | ||
* | ||
* \since QGIS 3.42 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the PR must be backported to release-3_40 branch, shouldn't this method be tagged as "since QGIS 3.40" or will it be adapted somehow for QGIS 3.40 in the backporting PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I don't think so (But not 100% sure). IIRC, that's the way we deal with such scenario, because the modification wouldn't be effective in 3.4.0 only in 3.40.3 and that could lead to misunderstanding for people who would read the documentation.
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Description
This PR fixes processing algorithm feature iteration against a model.
Fixes #60131.