Fix network redirect handling to be compatible for both Qt5 and Qt6 #60238
+32
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
|
@nirvn wouldn't it be better to remove all manual redirect handling from qgis? It's annoying fragile code which we could safely drop. |
|
@nyalldawson , hm not completely sure we could go that easily. I'm seeing some weird caching of redirected content. Plus there's some unsafe redirection we tolerate ATM I think. My suggestion would be to go for this as a short term fix then rethink how we want to do this overall. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #60235 . More details are in the issue, but basically QGIS' handling of redirects was not compatible with Qt6's changed default policy for redirects. The PR heals that by manually setting the policy to what QGIS expects.