Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try not to depend on stringr #9

Open
benubah opened this issue Jul 28, 2022 · 1 comment
Open

Try not to depend on stringr #9

benubah opened this issue Jul 28, 2022 · 1 comment
Labels
todo Something in the plan

Comments

@benubah
Copy link
Contributor

benubah commented Jul 28, 2022

do we know where this script will be run? if it's run on server/in Docker/somehow deployed, I would recommend using base R regex. stringr brings stringi which in my experience is quite a heavy dependency.

OTOH, if this script will only be run manually / locally, using stringr will be fine :)

Originally posted by @MichaelChirico in r-devel/translations#5 (comment)
@benubah benubah added the todo Something in the plan label Jul 28, 2022
@hturner hturner mentioned this issue Apr 25, 2024
Closed
@hturner hturner mentioned this issue Sep 30, 2024
Open
@koduu
Copy link

koduu commented Oct 9, 2024

I started with a refactor, seems feasible enough, though the performance most certainly takes a slight hit. I am currently doing the fixes into a forked version (https://github.com/koduu/translations-dashboard), will talk with @hturner to see how to get it merged to the main repo later on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
todo Something in the plan
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

9-try-not-to-depend-on-stringr r-devel/translations-dashboard
2 participants
@benubah @koduu