Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to "Pop" Video Back into YouTube #16

Open
rthaut opened this issue Mar 19, 2018 · 3 comments
Open

Ability to "Pop" Video Back into YouTube #16

rthaut opened this issue Mar 19, 2018 · 3 comments

Comments

@rthaut
Copy link
Owner

rthaut commented Mar 19, 2018

After opening a video in the popout player, it would be nice to be able to "pop" the video back into YouTube (even if the original YouTube window/tab was closed).

For the implementation, this would likely mean:

  1. Tracking the original window/tab when the popout player was opened
  2. When the user wants to pop the video back, determine if the original window/tab is still open
  3. If so, send a message to the original window/tab to just jump the video to the current time and resume playback
  4. If not, create a new tab with the "normal" video URL at the current time
  5. Close the popout player window

This should be possible in the Web Extension, but probably not possible in the userscript version (unless pure JavaScript messaging is used instead of the Web Extension APIs for messaging).

@rthaut
Copy link
Owner Author

rthaut commented Jan 22, 2019

This may not be needed, as the embedded YouTube player (used for the popout window) typically shows a "YouTube" button for opening the video on the full YouTube site.

The only real difference between the existing (native) functionality and what was proposed in this request is that the existing (native) button does NOT update the original tab/window (if the user left it open when opening the popout player). Instead, it simply opens another window/tab altogether, so the video would then be open in 2 regular windows/tabs (plus the popout window), although the original one and the popout one are both paused.

As such, I'm going to leave this open, but the priority for implementing this is low.

@rthaut
Copy link
Owner Author

rthaut commented Jan 22, 2019

#25 complicates this a little bit, as it hides the custom controls in the popout player (although users can disable that to restore the custom controls in the popout player).

So there could be a need for several settings related to the custom controls in the popout player in order to accommodate both requests:

  • Hide controls completely
  • Show controls (pop out only)
  • Show controls (pop in only)
  • Show controls (both pop out and pop in)

@rthaut
Copy link
Owner Author

rthaut commented Jan 26, 2019

#32 probably further complicates this, as that would allow the user to hide all video player controls (not just the custom popout player button) on the popout player.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant