Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 [#17555] fix openai.BadRequestError: Invalid value for 'content': expected a string, got null. #17556

Conversation

upchunk
Copy link
Contributor

@upchunk upchunk commented Jan 20, 2025

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #17555

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new / edit existing unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 20, 2025
…Invalid-value-for-'content'--expected-a-string,-got-null-
…Invalid-value-for-'content'--expected-a-string,-got-null-
@upchunk
Copy link
Contributor Author

upchunk commented Jan 22, 2025

@logan-markewich I have changed the logic to follow OpenAI API Reference strictly and revert the unit test.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 22, 2025
@logan-markewich logan-markewich enabled auto-merge (squash) January 22, 2025 16:22
@logan-markewich logan-markewich merged commit b1ff522 into run-llama:main Jan 22, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: openai.BadRequestError: Error code: 400. Invalid value for 'content': expected a string, got null
2 participants