@smol-ninja I’ve started working on this issue, but I’m unsure about the best approach regarding the stream creator examples in lockup.

Currently, we have a separate file for each model example:

lockup
├── BatchLDStreamCreator.sol
├── BatchLLStreamCreator.sol
├── BatchLTStreamCreator.sol
├── LockupDynamicCurvesCreator.sol
├── LockupDynamicStreamCreator.sol
├── LockupLinearStreamCreator.sol
└── LockupTranchedStreamCreator.sol

With the new singleton approach, we could technically move everything into a single file, but IMO, we should keep the current structure. I believe it is better organized to have a dedicated example page in the docs for each model.
wdyt?

we should keep the current structure

Yes. The user would know which lockup model to use so it makes sense to have one example contract per model to make it less complicated to read.

In Airdrops dir, we would also need createLTAirstream contract since we only have createLLAirstream right now.

• Should we add separate examples with how to create Linear stream with start unlock, cliff unlock etc?
• Should we add more examples of batch?

In Airdrops dir, we would also need createLTAirstream contract since we only have createLLAirstream right now.

agree

Should we add separate examples with how to create Linear stream with start unlock, cliff unlock etc?

yeah, i was thinking of editing the current LockupLinearStreamCreator to be similar to LockupDynamicCurvesCreator, but with all possible shapes (from the PR OP).
wdyt?

Should we add more examples of batch?

if we decide to remove the BatchLockup, IMO we should have something like we do for flow

Sounds good,

if we decide to remove the BatchLockup, IMO we should

I think regardless of that, one or two examples with batch would be useful. We don't need that many, as once a user understands how to use batch, he can do whatever he wants with it.