Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what kind of menu #11

Open
wdehoog opened this issue Aug 24, 2018 · 13 comments
Open

what kind of menu #11

wdehoog opened this issue Aug 24, 2018 · 13 comments
Labels
question Further information is requested

Comments

@wdehoog
Copy link
Collaborator

wdehoog commented Aug 24, 2018

Currently hutspot has two kind of menus:

  1. a docked panel with buttons, shown when pressing the 'burger' icon
  2. a page with a list of items, shown when pressing the 'burger' icon or as an attached page of the player

Which one shall hutspot use? How will it be shown? Are there any other ways a menu could be shown ?

@wdehoog wdehoog added the question Further information is requested label Aug 24, 2018
@rgrnetalk
Copy link

This was what confuses me most, but both option are nice (good to develop both of them!)

  1. the docked panel could come from under the header just like the filebrowser app does (that way is the distance between the button click and the actual panel much smaller). this way the panel can be used at every page without navigation confusion
    2, I used this option my adapted version and created a pullmenu choice menu which opens the menu. But is more confusing because the navigation is not that clear (there is no nice sequence in pages in the user scenario).

@rgrnetalk
Copy link

rgrnetalk commented Aug 29, 2018

I have adapted the docker navigation panel to cover 2/3 of the page shown (the panel is opened by the first pulley menu choice. Here the result:
image
(the genre and mood page is indicated by the ambience icon and the devices are indicated by the devices icon).

The only problem is that the pulley menu cannot be used for all pages (e.g. devices pages has standard no pulley menu)

@wdehoog
Copy link
Collaborator Author

wdehoog commented Aug 29, 2018

Looks nice. Ambiance icon is a great idea. What is the problem with adding a pulley to the pages that don't have one?

@rgrnetalk
Copy link

The LoadPullMenus has some other menu choices in it (Reload, Load Previous Set and Load Next Set) so that cannot be used for the devices and the settings page. Simply adding the pulleymenu to the page is not possible, because it has to open the component (id: navPanel) which it has no access to. Making a seperate pulleymenu component isn't possible because devices already has a menu (reload devices).

@wdehoog
Copy link
Collaborator Author

wdehoog commented Aug 29, 2018

Devices and Settings are indeed sort of 'modal'. I guess if you want you could add

    NavigationPanel {
        id: navPanel
    }

and

        anchors.bottom: navPanel.top
        clip: navPanel.expanded

like the other pages have as well.

@wdehoog
Copy link
Collaborator Author

wdehoog commented Oct 11, 2018

I have been working on a docked panel. It appears on most pages. When scrolling a list the panel will hide so more items are visible.

Currently it shows the album-art, prev/play/next buttons a hamburger icon for showing the menu list, and a progress indicator.

I'd like to merge it but only if others like this change as well.

It is in my own repo in the controlpanel2 branch. A build of my version can be found here: http://repo.merproject.org/obs/home:/wdehoog:/hutspot-wj/sailfish_latest_armv7hl/armv7hl/

new-control-panel

@ksiazkowicz
Copy link
Contributor

I'm not a big fan of hamburger menus but honestly, looks pretty nice to me. There is a small bug with menu, it looks like you could swipe left to go to the next page, but there is no page. I guess we could merge it anyway and figure it out later.

@ksiazkowicz
Copy link
Contributor

About pulley menus, it could be freed up with some kind of infinite loading mechanism.

@wdehoog
Copy link
Collaborator Author

wdehoog commented Oct 12, 2018

merged. yes auto loading prev/next instead of pullies sounds nice.
I think the swipe left page indicator is the dimmed Accept one of the dialog. when showNavigationIndicator: false it is gone but then the Back one is also gone.

@ksiazkowicz
Copy link
Contributor

Is scrolling behaving weird on your device as well? It looks like bottom pulley + docked panel results in a buggy mess:
https://1drv.ms/v/s!ApF6BBqdJeSZkLNlRRqb7-keP5p6VA

@wdehoog
Copy link
Collaborator Author

wdehoog commented Oct 16, 2018

Yes. It is hard to have the docked panel sliding in and out while the push-up menus remain working and the last item not becoming inaccessible. I don't really know how to fix this.

@rgrnetalk
Copy link

No problem in my solution. Docked panel stays at the bottom page. Listview scroll scrolls to the end and when pulling it up I see the pulley menu. Let me investigate where the differences are.

@rgrnetalk
Copy link

My background panel has the following properties:
height: navPanel.open? playingPage.height * 2/3 : col.height
opacity: navPanel.open ? 0.0 : 1.0
(but it's my adapted version with the menu panel sliding in from the bottom).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants