Replies: 1 comment 3 replies
-
|
Hi @unk1911, thanks for using simple-openai! In the logs that you shared, I can see that OpenAI has taken your question and it has decided to make two calls to your function
So, you must provide a 'tool' message per every tool_call, however, you are providing a 'tool' message for only one ( I suggest studying the code of the ConversationDemo.java to see how to answer for multiple tool_calls. |
Beta Was this translation helpful? Give feedback.
-
|
Hi @sashirestela, thanks for your detailed help. i was able to get my code to work for the specific example listed here by reviewing the ConversationDemo.java and adjusting my code. however, after i did that and ran a regression jUnit test to test a previous prompt, namely: "what is the latest news from [Ukraine]? today is 2024-10-13", this resulted in a toolCalls array containing just one element, in the debugger it looked like this: note that the problem with this is the function in this case has the name = null, even though the arguments are properly populated. so because the function name wasn't properly populated, this threw the following Exception when i tried to run it: i ultimately found a workaround for this, by essentially combining both methods, the previous method that i was using, from which i would check to see how many elements are in the toolCalls array, and if that number is 1, then to use the old method that i used earlier, and if that number is greater than 1, then to use the chatStream method that you had recommended. of course ideally it would be great if i could just make one call which would work uniformly regardless of the number of elements in the toolCalls array. i think this may be a bug in your implementation? |
Beta Was this translation helpful? Give feedback.
-
|
@unk1911 Thanks for identifying that missing scenario in the demo code. The ConversationDemo's code needs to be updated to handle single function calls in addition to multiple functions calls. You need to change the Code Details
private Choice getResponse(Stream<Chat> chatStream) {
var choice = new Choice();
choice.setIndex(0);
var chatMsgResponse = new ResponseMessage();
List<ToolCall> toolCalls = new ArrayList<>();
chatStream.forEach(responseChunk -> {
var choices = responseChunk.getChoices();
if (choices.size() > 0) {
var innerChoice = choices.get(0);
var delta = innerChoice.getMessage();
if (delta.getRole() != null) {
chatMsgResponse.setRole(delta.getRole());
}
if (delta.getContent() != null && !delta.getContent().isEmpty()) {
content.append(delta.getContent());
System.out.print(delta.getContent());
}
if (delta.getToolCalls() != null) {
var toolCall = delta.getToolCalls().get(0);
if (toolCall.getIndex() != indexTool) {
if (toolCalls.size() > 0) {
toolCalls.get(toolCalls.size() - 1).getFunction().setArguments(functionArgs.toString());
functionArgs = new StringBuilder();
}
toolCalls.add(toolCall);
indexTool++;
} else {
functionArgs.append(toolCall.getFunction().getArguments());
}
}
if (innerChoice.getFinishReason() != null) {
if (content.length() > 0) {
chatMsgResponse.setContent(content.toString());
}
if (toolCalls.size() > 0) {
toolCalls.get(toolCalls.size() - 1).getFunction().setArguments(functionArgs.toString());
chatMsgResponse.setToolCalls(toolCalls);
}
choice.setMessage(chatMsgResponse);
choice.setFinishReason(innerChoice.getFinishReason());
}
}
});
return choice;
}I ran the demo with that version and got the expected behavior: Output Example
Welcome! Write any message: Explain in a short message what is a rectangle triangle.
A right triangle, also known as a right-angled triangle, is a type of triangle that has one angle measuring
90 degrees. The side opposite the right angle is called the hypotenuse, while the other two sides are referred
to as the legs. The Pythagorean theorem applies to right triangles, stating that the square of the hypotenuse's
length is equal to the sum of the squares of the lengths of the other two sides.
Write any message (or write 'exit' to finish): What are the latest news from [Ukraine, Colombia]? Today is 2024-10-17
Here are the latest news updates:
**Ukraine:** President Volodymyr Zelensky has presented a "victory plan" to MPs, aimed at strengthening
Ukraine's position to end the ongoing war with Russia.
**Colombia:** Seventeen people were injured in a drone attack that occurred after a military operation aimed
at uprooting guerrilla groups from a town in southwest Colombia.
Write any message (or write 'exit' to finish): What are the latest news from [Ukraine]? Today is 2024-10-17
The latest news from Ukraine is that President Volodymyr Zelensky has presented a long-awaited "victory plan"
to MPs, which aims to strengthen the country's position in order to end the war with Russia.
Write any message (or write 'exit' to finish): exitIf you find this project valuable there are a few ways you can show us your love, preferably all of them 🙂:
|
Beta Was this translation helpful? Give feedback.
-
|
thank you, now it works perfectly, handling both 0, 1, and >1 cases |
Beta Was this translation helpful? Give feedback.
-
it would seem that if my prompt is more complex and contains requests for multiple things, i get an error when using the Simple-Openai.
for example here's an error i get if my prompt is: "what the latest news from [Ukraine, Colombia]? today is 2024-10-13":
but if i keep my question simple, like:
"what the latest news from [Ukraine]? today is 2024-10-13":
then it works every time. but i'm hoping to have it work regardless of how the question is asked by the user, if it's about 1 thing or 4 things..
-m
Beta Was this translation helpful? Give feedback.
All reactions