Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Stamen tiles + fix other deprecations #330

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

AmitAronovitch
Copy link
Contributor

@AmitAronovitch AmitAronovitch commented Jan 4, 2025

Resolves #329

This PR is for making telluric work with more up-to-date versions python and packages.

Changes included so far:

  1. Use CartoDB refernce maps instead of Stamen (which are not available any more - see folium #1803
  2. Remove dependency on deprecated pkg_resources (not required for Python>=3.7)
  3. Fix some failing tests and linters

@matiasg
Copy link

matiasg commented Jan 23, 2025

Hi, @AmitAronovitch !!
Are you still using telluric? Do you want me to try find somebody to review the PR?

@AmitAronovitch
Copy link
Contributor Author

Hi, @AmitAronovitch !! Are you still using telluric? Do you want me to try find somebody to review the PR?

Hi @matiasg , yes that would be great :-)

Note however that releasing a new version of telluric still requires some work.

This is because the dependencies (mainly rasterio) had moved forwards and we need to change stuff if we want to telluric to use supported versions of its dependencies...

My branch fixes some issues, but there are some failing tests which I am not sure what to do with (it seems to be some regression test related to fixup of rounding issues at the edges of windows. It breaks because rasterio had changed the way it rounds up its images, but I do not have the rasters that the old telluric issue was trying to fix, so cannot verify that fixing the code does not re-break them).
I will add more info on this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reference maps not working anymore
2 participants