Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skuba migrate node 22 #1735

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open

skuba migrate node 22 #1735

wants to merge 38 commits into from

Conversation

zbrydon
Copy link
Contributor

@zbrydon zbrydon commented Nov 13, 2024 •
edited
Loading

Resolves #1549

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: ed14a1b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@zbrydon zbrydon mentioned this pull request Nov 13, 2024
Open
17 tasks
AaronMoat
AaronMoat reviewed Nov 13, 2024
View reviewed changes
src/cli/migrate/nodeVersion/getNode22TypesVersion.ts Outdated Show resolved Hide resolved
src/cli/migrate/index.ts Outdated Show resolved Hide resolved
zbrydon
zbrydon commented Nov 20, 2024
View reviewed changes
src/cli/migrate/nodeVersion/packageJsonChecks.test.ts Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel we need to test how this behaves in a file structure, would the best way to do this be by utilising memfs?

@zbrydon zbrydon marked this pull request as ready for review January 15, 2025 23:24
@zbrydon zbrydon requested a review from a team as a code owner January 15, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samchungy samchungy samchungy left review comments

@AaronMoat AaronMoat AaronMoat left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@AaronMoat AaronMoat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node 22 support
3 participants
@zbrydon @AaronMoat @samchungy