Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output switch-maps pdf as part of the release #773

Open
sarcasticadmin opened this issue Sep 22, 2024 · 2 comments
Open

output switch-maps pdf as part of the release #773

sarcasticadmin opened this issue Sep 22, 2024 · 2 comments

Comments

@sarcasticadmin
Copy link
Member

Description

Switch-maps should be included as a release artifact. They are simple enough to generate: make config/switch-maps/stickers.pdf

Acceptance Criteria

  • switch-maps are an artifact of the release
@owendelong
Copy link
Collaborator

Can you clarify what needs to be done for this to be achieved? What is a "release" in this context and forgive my ignorance as to the definition of the term artifact in this context.

I suspect that if we're including the sticker PDF in the release, we should probably be including the full set of switch configurations, etc. as well, in which case, "make all" or "make" without arguments is probably the better choice for the generation process.

@sarcasticadmin
Copy link
Member Author

Can you clarify what needs to be done for this to be achieved? What is a "release" in this context and forgive my ignorance as to the definition of the term artifact in this context.

A release is a concept of associating additional files with things like a tag. For example see one of our recent releases where we include the openwrt images with the 21.0 tag: https://github.com/socallinuxexpo/scale-network/releases/21.0

I suspect that if we're including the sticker PDF in the release, we should probably be including the full set of switch configurations, etc. as well, in which case, "make all" or "make" without arguments is probably the better choice for the generation process.

We need to include it in a github action that creates a release when a given git tag is created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants