Refactor ratio #2038
Open
Refactor ratio #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
还是统一使用 ctxkey 比较好，你可以让 |
|
请教下这个重构的意义是什么，带来了什么新功能吗或解决了什么问题吗？ |
See #2023 |
|
看了下，感觉很不错。不过我觉得没必要在页面上保留那两个【已废弃】，能自动将历史数据转为新格式就更好了。 |
Good idea~ 已经实现了 截图中展示旧的倍率
新代码启动之后，自动迁移到新倍率中
导入一次之后，新倍率会写到 options 表中
可以在次基础上修改新倍率
再次重启 one-api，新倍率已持久化，不会被旧倍率覆盖 之后的版本中可以删除 ModelRatio, CompletionRatio 相关代码和配置 |
|
Hi @songquanpeng, would you please help review and merge the code? |
|
感觉是多此一举，补全倍率很少去配置，这样修改后反而每个模型都要配置补全，反向优化 |
这里稍微改几行就可以实现支持缺省的补全倍率。 one-api/relay/billing/ratio/model.go Lines 419 to 423 in f2bff58 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2023
我已确认该 PR 已自测通过，相关截图如下：
默认倍率
自定义倍率配置
自定义倍率前后对比
