Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reload certificates after every minute #43859

Open
soloturn opened this issue Jan 16, 2025 · 1 comment
Open

reload certificates after every minute #43859

soloturn opened this issue Jan 16, 2025 · 1 comment
Labels
status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged

Comments

@soloturn
Copy link

current implementation can be made to watch certificate and reload on change. that sounds a little complex, and has edge cases, like symbolic links. can it be not made to reload the cert every minute or so? the overhead is minimal, and in most cases time based relaod is sufficient.

https://spring.io/blog/2023/11/07/ssl-hot-reload-in-spring-boot-3-2-0

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 16, 2025
@wilkinsona
Copy link
Member

The code has already been written and, as far as we know, it's working well and hasn't resulted in a big maintenance burden. As such, I don't think the complexity is too high and the edge cases have not (yet at least) been problematic. Given that watching is more efficient and appears to function well, what benefit to users would there be in schedule-based reloading?

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

No branches or pull requests

3 participants